Closed icweaver closed 2 years ago
This is awesome!! Let's do the DatePicker in a new PR?
Some extra comments:
""
(this happens when no time is chosen yet), then that should be converted to the Julia object nothing
, not to 00:00
.Then about seconds:
It looks like the <input type=time step=1>
element will show seconds (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/time#time_value_format).
[ ] I think we should have a keyword parameter TimePicker(show_seconds=true)
to control whether we want to show it.
[ ] When the GUI is not showing seconds, then the seconds part of the default value should be discarded. i.e. the default of TimeField(default=Time(23,59,44), show_seconds=false)
should be Time(23,59,00)
.
About min/max: it looks like the min
and max
attributes have no effect in Chrome, so it's probably not worth the effort to implement them.
Sounds good, thanks for the tips! I think I am going to be a little pressed for time this week, but can definitely get this started sometime this weekend!
TIL renaming a branch (even on a draft PR) deletes the original, my b
Hey all, happy new year! Just following up on #169. Sort of flying by the seat of my pants here, but is this kind of what we had in mind for it? Happy to add in
DatePicker
+ some docs next if this is starting on the right trackDemo