JuliaPluto / PlutoUI.jl

https://featured.plutojl.org/basic/plutoui.jl
The Unlicense
299 stars 54 forks source link

Dark background for TOC #193

Closed pankgeorg closed 2 years ago

github-actions[bot] commented 2 years ago

Try this Pull Request!

Open Julia and type:

  julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/JuliaPluto/PlutoUI.jl", rev="toc-dark-mode")
julia> using PlutoUI

Or run this code in your browser: Run with binder

icweaver commented 2 years ago

This is awesome, thanks for working on this Panagiotis! Not sure if this is the right place, but I was wondering if the "Edit or run this notebook" button could also get a little TLC?

Screenshot from 2022-01-22 11-15-51

I'd be happy to start a PR for this to get the ball rolling if it doesn't require too much Pluto magic 🪄

fonsp commented 2 years ago

hmmmmmm but this is using Pluto's internal CSS variables! Weren't you the one who told me that widget authors surely won't use those and create their own CSS variables?

fonsp commented 2 years ago

@icweaver well spotted! That button is part of Pluto itself, but it is a bit difficult to work on because ~you can only see it on the export output, which uses Pluto's CSS from the last release... You either have to set up a local file server to replace the pluto CDN while developing (or you just~ okay I decided to just quickly fix this instead :) https://github.com/fonsp/Pluto.jl/commit/111960219770272ff8c1a700f1f894bf50348db9

pankgeorg commented 2 years ago

hmmmmmm but this is using Pluto's internal CSS variables! yes!

Weren't you the one who told me that widget authors surely won't use those and create their own CSS variables?

I said that widget authors can override those while using them on their own styles! Take a look at this, where I do exactly that :)

icweaver commented 2 years ago

Was hoping to bump this. It looks so good!

icweaver commented 2 years ago

thank-you