search

JuliaPluto / PlutoUI.jl

https://featured.plutojl.org/basic/plutoui.jl
The Unlicense
302 stars 55 forks source link

Dark mode #194

Closed Nagefire closed 2 years ago

Nagefire commented 2 years ago

As of version 0.17.7, Pluto supports dark mode but the widgets in PlutoUI don't match the color scheme. Are there plans to make PlutoUI dark mode compatible as well?

pankgeorg commented 2 years ago

As of version 0.17.7, Pluto supports dark mode but the widgets in PlutoUI don't match the color scheme.

Which widgets do you refer to?

Nagefire commented 2 years ago

From what I've tested the table of contents, sliders, select boxes, and fields don't match the dark theme.

plutoui

pankgeorg commented 2 years ago

I see plans for the table of contents in a pr https://github.com/JuliaPluto/PlutoUI.jl/pull/193, I don't know about the rest!

fonsp commented 2 years ago

Modern browsers will also render HTML5 inputs in dark mode, including Chrome and Safari, because we set https://developer.mozilla.org/en-US/docs/Web/CSS/color-scheme . What browser and version do you have? Can you try updating?

fonsp commented 2 years ago

https://web.dev/color-scheme/#demo

We made the choice to not style the built-in HTML5 inputs (slider, textfield, date) to make them look familiar to users, so adding a dark mode for those is outside the scope for Pluto, and instead, in the scope of your browser to implement.

fonsp commented 2 years ago

But for the table of contents, thank you for opening the issue! We were able to fix this in #193 .

I also added a dark mode for Scrubbable and Clock, so I think we can close this issue now!