JuliaPluto / PlutoUI.jl

https://featured.plutojl.org/basic/plutoui.jl
The Unlicense
299 stars 54 forks source link

Add downsampling function to Slider #219

Closed wilsongoode closed 1 year ago

wilsongoode commented 1 year ago

Updated Slider with:

Important:

github-actions[bot] commented 1 year ago

Try this Pull Request!

Open Julia and type:

  julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/wilsongoode/PlutoUI.jl", rev="main")
julia> using PlutoUI

Or run this code in your browser: Run with binder

fonsp commented 1 year ago

Awesome, thank you!!

You can add these https://github.com/JuliaPluto/PlutoUI.jl/issues/212#issuecomment-1155809643 to runtests.jl, and use PlutoUI.BuiltinsNotebook.downsample instead of downsample.

fonsp commented 1 year ago

Next time, make sure that you create a new branch on your fork, and do your work on that branch, instead of the main branch of your fork. This makes it easier to create a second pull request, and it avoids mixing up this PR with other work going on in the package 🌟

fonsp commented 1 year ago

wilsongoode commented 1 year ago

Next time, make sure that you create a new branch on your fork, and do your work on that branch, instead of the main branch of your fork. This makes it easier to create a second pull request, and it avoids mixing up this PR with other work going on in the package 🌟

Thanks for the tip! I haven't done this before so it's great to have helpful feedback.