search

JuliaPolyhedra / Polyhedra.jl

Polyhedral Computation Interface
Other
174 stars 27 forks source link

UndefVarError with `default_library(d::FullDim, ::Type{T})` #118

Closed oyamad closed 6 years ago

oyamad commented 6 years ago

116 having been merged, default_library(d::FullDim, ::Type{T}) now raises an error, despite what the documentation says:

https://github.com/JuliaPolyhedra/Polyhedra.jl/blob/209d7d3fbb01d52f5f65078c3989e0a44020957b/src/default.jl#L24-L28

using Polyhedra
A = [1. 1; 1 -1; -1 0]
b = [1, 0, 0]
rep = hrep(A, b)
plib = default_library(FullDim{2}(), Float64)
ERROR: UndefVarError: FullDim not defined
blegat commented 6 years ago

FullDim has now a different definition, it is Union{Int, StaticArrays.Size}. Here you should just do

plib = default_library(2, Float64)