JuliaPolyhedra / Polyhedra.jl

Polyhedral Computation Interface

Other

174 stars 27 forks source link

Use convert instead of constructor #143

Closed blegat closed 5 years ago

blegat commented 5 years ago

The constructor does not fallback to convert anymore on Julia v1.0

coveralls commented 5 years ago

Coverage increased (+1.07%) to 74.822% when pulling b7b39969ba61624016f5ebd6555179551788c14f on bl/convert into 98e9c46b0d84fd4e51e9adc0006d41db8f3c1754 on master.

coveralls commented 5 years ago

Coverage increased (+1.07%) to 74.822% when pulling b7b39969ba61624016f5ebd6555179551788c14f on bl/convert into 98e9c46b0d84fd4e51e9adc0006d41db8f3c1754 on master.

codecov[bot] commented 5 years ago

Codecov Report

Merging #143 into master will increase coverage by 1.06%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   73.75%   74.82%   +1.06%     
==========================================
  Files          33       33              
  Lines        1684     1684              
==========================================
+ Hits         1242     1260      +18     
+ Misses        442      424      -18

Impacted Files	Coverage Δ
src/elements.jl	`71.42% <100%> (+0.71%)`	:arrow_up:
src/show.jl	`71.92% <0%> (+7.01%)`	:arrow_up:
src/opt.jl	`77.27% <0%> (+9.09%)`	:arrow_up:
src/center.jl	`61.76% <0%> (+32.35%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 98e9c46...b7b3996. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #143 into master will increase coverage by 1.06%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   73.75%   74.82%   +1.06%     
==========================================
  Files          33       33              
  Lines        1684     1684              
==========================================
+ Hits         1242     1260      +18     
+ Misses        442      424      -18

Impacted Files	Coverage Δ
src/elements.jl	`71.42% <100%> (+0.71%)`	:arrow_up:
src/show.jl	`71.92% <0%> (+7.01%)`	:arrow_up:
src/opt.jl	`77.27% <0%> (+9.09%)`	:arrow_up:
src/center.jl	`61.76% <0%> (+32.35%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 98e9c46...b7b3996. Read the comment docs.