JuliaPolyhedra / Polyhedra.jl

Polyhedral Computation Interface

Other

174 stars 27 forks source link

Update operations notebook #144

Closed mforets closed 5 years ago

mforets commented 5 years ago

Closes #142.

blegat commented 5 years ago

As it creates new polyhedra, it does not require any modification to the rest of the notebook. Could you rebase it to only contain the modification that are relevant (e.g. with git add -p) ? Note that you can add [ci skip] at the beginning of the commit message to avoid triggering CI since the examples are not covered

coveralls commented 5 years ago

Coverage remained the same at 74.896% when pulling 28ee08055045118fc069725f88911d4bf44f6703 on mforets:mforets/convexhull into b9b4d8ba000e9907bbed152f537aa74f6319e0a1 on JuliaPolyhedra:master.

codecov[bot] commented 5 years ago

Codecov Report

Merging #144 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   74.89%   74.89%           
=======================================
  Files          33       33           
  Lines        1685     1685           
=======================================
  Hits         1262     1262           
  Misses        423      423

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b9b4d8b...28ee080. Read the comment docs.

mforets commented 5 years ago

Done. Let me know if it is good now. For some reason when i open the original notebook as it is from master, the figures are note shown. This is why i re-run all the notebook in the first place.