JuliaPolyhedra / Polyhedra.jl

Polyhedral Computation Interface
Other
172 stars 27 forks source link

🐛 Fix method ambiguity #147 #148

Closed blegat closed 5 years ago

blegat commented 5 years ago

Closes #147

coveralls commented 5 years ago

Coverage Status

Coverage increased (+11.6%) to 86.189% when pulling 8c5a2ab971032e842c0c609d1aef82e94c1606ac on bl/fix147 into 5862f9909ccc7555a4ca7f15c7639145457622ed on master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+11.6%) to 86.189% when pulling 8c5a2ab971032e842c0c609d1aef82e94c1606ac on bl/fix147 into 5862f9909ccc7555a4ca7f15c7639145457622ed on master.

codecov[bot] commented 5 years ago

Codecov Report

Merging #148 into master will increase coverage by 11.76%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #148       +/-   ##
===========================================
+ Coverage   74.59%   86.36%   +11.76%     
===========================================
  Files          33       33               
  Lines        1685     1716       +31     
===========================================
+ Hits         1257     1482      +225     
+ Misses        428      234      -194
Impacted Files Coverage Δ
src/default.jl 72.09% <0%> (+7.8%) :arrow_up:
src/vecrep.jl 97.14% <0%> (+2.85%) :arrow_up:
src/comp.jl 97.22% <0%> (+2.93%) :arrow_up:
src/Polyhedra.jl 53.33% <0%> (+3.33%) :arrow_up:
src/representation.jl 83.33% <0%> (+4.16%) :arrow_up:
src/opt.jl 81.81% <0%> (+4.54%) :arrow_up:
src/indices.jl 82.14% <0%> (+4.87%) :arrow_up:
src/iterators.jl 96.22% <0%> (+5.66%) :arrow_up:
src/projection.jl 78.43% <0%> (+5.88%) :arrow_up:
src/repop.jl 94.59% <0%> (+6.75%) :arrow_up:
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5862f99...8c5a2ab. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #148 into master will increase coverage by 11.76%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #148       +/-   ##
===========================================
+ Coverage   74.59%   86.36%   +11.76%     
===========================================
  Files          33       33               
  Lines        1685     1716       +31     
===========================================
+ Hits         1257     1482      +225     
+ Misses        428      234      -194
Impacted Files Coverage Δ
src/default.jl 72.09% <0%> (+7.8%) :arrow_up:
src/vecrep.jl 97.14% <0%> (+2.85%) :arrow_up:
src/comp.jl 97.22% <0%> (+2.93%) :arrow_up:
src/Polyhedra.jl 53.33% <0%> (+3.33%) :arrow_up:
src/representation.jl 83.33% <0%> (+4.16%) :arrow_up:
src/opt.jl 81.81% <0%> (+4.54%) :arrow_up:
src/indices.jl 82.14% <0%> (+4.87%) :arrow_up:
src/iterators.jl 96.22% <0%> (+5.66%) :arrow_up:
src/projection.jl 78.43% <0%> (+5.88%) :arrow_up:
src/repop.jl 94.59% <0%> (+6.75%) :arrow_up:
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5862f99...8c5a2ab. Read the comment docs.