JuliaPolyhedra / Polyhedra.jl

Polyhedral Computation Interface
Other
172 stars 27 forks source link

Adds MOI.LOCALLY_SOLVED as an acceptable return code for hchebyshevcenter() #177

Closed ferrolho closed 5 years ago

ferrolho commented 5 years ago

Example code for the matter:

hchebyshevcenter(polyhedron(vrep(rand(10, 3))), with_optimizer(Ipopt.Optimizer, print_level=0))

Output before change:

Solver returned LOCALLY_SOLVED when computing the H-Chebyshev center.

Stacktrace:
 [1] error(::String) at ./error.jl:33
 [2] hchebyshevcenter(::DefaultPolyhedron{Float64,MixedMatHRep{Float64,Array{Float64,2}},MixedMatVRep{Float64,Array{Float64,2}}}, ::OptimizerFactory) at /home/henrique/.julia/dev/Polyhedra/src/center.jl:35
 [3] top-level scope at In[92]:1

Output after change:

([0.664083, 0.515307, 0.583585], 0.270949718678351)
coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 82.81% when pulling be87101f35a57e0f1b72c0b0329d55a1cd7c96f6 on ferrolho:master into ffb0574e67e9b0f56544bd47eaac992fa6240802 on JuliaPolyhedra:master.

codecov[bot] commented 5 years ago

Codecov Report

Merging #177 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #177   +/-   ##
=======================================
  Coverage   83.88%   83.88%           
=======================================
  Files          32       32           
  Lines        1812     1812           
=======================================
  Hits         1520     1520           
  Misses        292      292
Impacted Files Coverage Δ
src/center.jl 94.59% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ffb0574...be87101. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #177 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #177   +/-   ##
=======================================
  Coverage   83.88%   83.88%           
=======================================
  Files          32       32           
  Lines        1812     1812           
=======================================
  Hits         1520     1520           
  Misses        292      292
Impacted Files Coverage Δ
src/center.jl 94.59% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ffb0574...be87101. Read the comment docs.