search

JuliaPolyhedra / Polyhedra.jl

Polyhedral Computation Interface
Other
174 stars 27 forks source link

Inconsistency in chebyshevcenter documentation #185

Open schillic opened 5 years ago

schillic commented 5 years ago

chebyshevcenter either calls hchebyshevcenter or vchebyshevcenter depending on the argument. However, according to the documentation, these two functions compute different things.

https://github.com/JuliaPolyhedra/Polyhedra.jl/blob/00173cec89b318ec2d06b585e7b8510a91e130f6/src/center.jl#L5-L7

https://github.com/JuliaPolyhedra/Polyhedra.jl/blob/00173cec89b318ec2d06b585e7b8510a91e130f6/src/center.jl#L53-L55

According to Wikipedia, these two definitions are not equivalent in general.

In geometry, the Chebyshev center of a bounded set Q having non-empty interior is the center of the minimal-radius ball enclosing the entire set Q, or alternatively (and non-equivalently) the center of largest inscribed ball of Q.

Is this intended?

blegat commented 5 years ago

No, V-chebyshev center should do something different but I never got the time to implement it.