search

JuliaPolyhedra / Polyhedra.jl

Polyhedral Computation Interface
Other
172 stars 27 forks source link

Fix subset check for sparse halfspace #196

Closed blegat closed 4 years ago

blegat commented 4 years ago

Closes https://github.com/JuliaOpt/MathOptInterface.jl/issues/1016 See https://github.com/blegat/EntropicCone.jl/pull/4#issuecomment-583452410

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.02%) to 82.964% when pulling c0348317d398c3b5346f2418d8e75cdfb9dfcb42 on bl/sparse_subset into 5b977a22587884cf9b27f84080a51d40d2bdd4b8 on master.

codecov[bot] commented 4 years ago

Codecov Report

Merging #196 into master will decrease coverage by 0.28%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage   84.05%   83.77%   -0.29%     
==========================================
  Files          32       32              
  Lines        1838     1837       -1     
==========================================
- Hits         1545     1539       -6     
- Misses        293      298       +5
Impacted Files Coverage Δ
src/default.jl 64.44% <0.00%> (-4.45%) :arrow_down:
src/aff.jl 64.28% <0.00%> (-3.58%) :arrow_down:
src/show.jl 88.88% <0.00%> (-1.86%) :arrow_down:
src/comp.jl 91.89% <0.00%> (-0.22%) :arrow_down:
src/repop.jl 91.76% <0.00%> (-0.19%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b977a2...c034831. Read the comment docs.

codecov[bot] commented 4 years ago

Codecov Report

Merging #196 into master will decrease coverage by 0.28%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage   84.05%   83.77%   -0.29%     
==========================================
  Files          32       32              
  Lines        1838     1837       -1     
==========================================
- Hits         1545     1539       -6     
- Misses        293      298       +5
Impacted Files Coverage Δ
src/default.jl 64.44% <0.00%> (-4.45%) :arrow_down:
src/aff.jl 64.28% <0.00%> (-3.58%) :arrow_down:
src/show.jl 88.88% <0.00%> (-1.86%) :arrow_down:
src/comp.jl 91.89% <0.00%> (-0.22%) :arrow_down:
src/repop.jl 91.76% <0.00%> (-0.19%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b977a2...c034831. Read the comment docs.