search

JuliaPolyhedra / Polyhedra.jl

Polyhedral Computation Interface
Other
172 stars 27 forks source link

Fix detectvlinearity #205

Closed blegat closed 4 years ago

blegat commented 4 years ago

The current version only match opposite rays and does not work with e.g. conichull([1, 0], [0, 1], [-1, -1]). The new LP-based approach does the trick.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.4%) to 83.931% when pulling d28ac635f0141479941946b39bf1485a748db451 on bl/detectvlin into 234cc550b723e889ec16ba2e14535f5c852adcee on master.

codecov[bot] commented 4 years ago

Codecov Report

Merging #205 into master will increase coverage by 0.43%. The diff coverage is 90.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
+ Coverage   84.53%   84.96%   +0.43%     
==========================================
  Files          33       33              
  Lines        1869     1916      +47     
==========================================
+ Hits         1580     1628      +48     
+ Misses        289      288       -1
Impacted Files Coverage Δ
src/center.jl 94.59% <ø> (ø)
src/opt.jl 73.07% <50.00%> (-0.93%) :arrow_down:
src/redundancy.jl 92.96% <90.76%> (-0.59%) :arrow_down:
src/aff.jl 78.57% <100.00%> (+10.71%) :arrow_up:
src/doubledescription.jl 62.50% <100.00%> (ø)
src/elements.jl 77.16% <100.00%> (+0.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 234cc55...d28ac63. Read the comment docs.