search

JuliaPolyhedra / Polyhedra.jl

Polyhedral Computation Interface
Other
174 stars 27 forks source link

LP-based linearity and redundancy for H-rep #206

Closed blegat closed 4 years ago

blegat commented 4 years ago

LP-based linearity detection was implemented in https://github.com/JuliaPolyhedra/Polyhedra.jl/pull/205 for V-rep and LP-based redundancy removal in https://github.com/JuliaPolyhedra/Polyhedra.jl/pull/174 for V-rep. This PR brings the same features for H-rep. Closes https://github.com/JuliaPolyhedra/Polyhedra.jl/issues/62

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.2%) to 84.111% when pulling 8e1e7aae95b896d8a36f6baec1068b2d210cb1e4 on bl/lph into bf7d295985f6adbadc1cc99b7de6f19c16d6d084 on master.

codecov[bot] commented 4 years ago

Codecov Report

Merging #206 into master will increase coverage by 0.13%. The diff coverage is 90.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
+ Coverage   84.96%   85.09%   +0.13%     
==========================================
  Files          33       34       +1     
  Lines        1916     1973      +57     
==========================================
+ Hits         1628     1679      +51     
- Misses        288      294       +6
Impacted Files Coverage Δ
src/Polyhedra.jl 34.78% <ø> (ø)
src/opt.jl 74.54% <84.61%> (+1.46%) :arrow_up:
src/linearity.jl 86.13% <86.13%> (ø)
src/redundancy.jl 93.60% <92.59%> (+0.63%) :arrow_up:
src/aff.jl 86.58% <100.00%> (+8.01%) :arrow_up:
src/defaultlibrary.jl 90.24% <100.00%> (ø)
src/doubledescription.jl 62.50% <100.00%> (ø)
src/elements.jl 77.30% <100.00%> (+0.14%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bf7d295...8e1e7aa. Read the comment docs.