search

JuliaPolyhedra / Polyhedra.jl

Polyhedral Computation Interface
Other
172 stars 27 forks source link

Specialized planar convex hull #223

Closed blegat closed 3 years ago

blegat commented 3 years ago

The 3D decomposition had a computation of the convex hull of the 2D facets that also supports rays and lines for a while, this PR extracts it as a separate planar_hull that is now called in removevredundancy! for 2D polyhedra.

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.3%) to 91.783% when pulling 3ea7eb8403dadf84376388d508c3b53c60f37938 on bl/planar_convex into e03b49c204546f0b2ad757826ee39a184f46b291 on master.

codecov[bot] commented 3 years ago

Codecov Report

Merging #223 into master will increase coverage by 0.06%. The diff coverage is 79.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   90.72%   90.79%   +0.06%     
==========================================
  Files          36       37       +1     
  Lines        2157     2215      +58     
==========================================
+ Hits         1957     2011      +54     
- Misses        200      204       +4
Impacted Files Coverage Δ
src/Polyhedra.jl 84.00% <ø> (ø)
src/recipe.jl 96.29% <ø> (+2.96%) :arrow_up:
src/decompose.jl 71.55% <37.77%> (-8.76%) :arrow_down:
src/planar.jl 100.00% <100.00%> (ø)
src/redundancy.jl 95.48% <100.00%> (+0.06%) :arrow_up:
src/elements.jl 84.40% <0.00%> (+0.53%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e03b49c...3ea7eb8. Read the comment docs.