search

JuliaPolyhedra / Polyhedra.jl

Polyhedral Computation Interface
Other
174 stars 27 forks source link

Implement named dimensions #225

Closed blegat closed 4 years ago

blegat commented 4 years ago

The LPHRep use a MathOptInterface model to encode the H-representation. As this model natively supports naming the variables, LPHRep actually supports naming the dimensions. This PR allows to retrieve these, pass these names along through transformations and sets these names to JuMP variables if the H-representation is used to create a vector of JuMP variables.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-1.0%) to 90.791% when pulling 407def5c56b6e0a44eda73b970d56a56c2a58bed on bl/dimension_names into 714433398e46b161cac38c60a2d94e2650abd5d6 on master.

codecov[bot] commented 4 years ago

Codecov Report

Merging #225 into master will decrease coverage by 1.30%. The diff coverage is 68.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   90.79%   89.48%   -1.31%     
==========================================
  Files          37       38       +1     
  Lines        2215     2311      +96     
==========================================
+ Hits         2011     2068      +57     
- Misses        204      243      +39
Impacted Files Coverage Δ
src/tmp.jl 0.00% <0.00%> (ø)
src/extended.jl 92.85% <83.33%> (-4.58%) :arrow_down:
src/lphrep.jl 88.09% <91.66%> (+0.25%) :arrow_up:
src/opt.jl 82.89% <92.85%> (-0.72%) :arrow_down:
src/default.jl 84.84% <96.00%> (+1.86%) :arrow_up:
src/center.jl 96.00% <100.00%> (ø)
src/projection_opt.jl 65.51% <100.00%> (-4.86%) :arrow_down:
src/repop.jl 90.52% <100.00%> (+0.52%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7144333...407def5. Read the comment docs.