search

JuliaPolyhedra / Polyhedra.jl

Polyhedral Computation Interface
Other
172 stars 27 forks source link

Avoid zero division in decompose #248

Closed blegat closed 3 years ago

blegat commented 3 years ago

This is making CDDLib and Polyhedra tests fail in Julia v1.6 due to the change fixed in https://github.com/JuliaLang/julia/pull/40551

codecov[bot] commented 3 years ago

Codecov Report

Merging #248 (d851b8a) into master (57858dc) will increase coverage by 1.66%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
+ Coverage   76.46%   78.12%   +1.66%     
==========================================
  Files          39       39              
  Lines        2961     3204     +243     
==========================================
+ Hits         2264     2503     +239     
- Misses        697      701       +4
Impacted Files Coverage Δ
src/vecrep.jl 100.00% <ø> (ø)
src/decompose.jl 73.38% <100.00%> (+2.59%) :arrow_up:
src/indices.jl 96.92% <0.00%> (-3.08%) :arrow_down:
src/comp.jl 91.30% <0.00%> (-1.01%) :arrow_down:
src/planar.jl 100.00% <0.00%> (ø)
src/mixedrep.jl 100.00% <0.00%> (ø)
src/polyhedron.jl 100.00% <0.00%> (ø)
src/triangulation.jl 100.00% <0.00%> (ø)
src/interval.jl 99.13% <0.00%> (+0.02%) :arrow_up:
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 57858dc...d851b8a. Read the comment docs.