JuliaPolyhedra / Polyhedra.jl

Polyhedral Computation Interface

Other

172 stars 27 forks source link

Update Documenter to v0.27 #265

Closed blegat closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #265 (5db5c2d) into master (e772525) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #265   +/-   ##
=======================================
  Coverage   78.08%   78.08%           
=======================================
  Files          39       39           
  Lines        3212     3212           
=======================================
  Hits         2508     2508           
  Misses        704      704

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e772525...5db5c2d. Read the comment docs.

schillic commented 3 years ago

@blegat We have the same segmentation fault in a package. Would be great if you figure it out for us :sweat_smile: EDIT: This could be related to Literate (another package that does not use Literate works fine).

blegat commented 3 years ago

I have opened an issue here: https://github.com/jheinen/GR.jl/issues/422 as the segfault seems to be in the GR library. Let's try to fix Literate to an older version.

schillic commented 3 years ago

I delta debugged a bit and the problem occurs when calling plot from within Literate (using the default GR but I did not try out other backends). Not sure where exactly the problem is yet.

schillic commented 3 years ago

I found the solution (at least for us) here: https://github.com/JuliaPlots/Plots.jl/issues/3650

Just add the change in the linked commits at the bottom: specifically you can add GKSwstype: nul to env in the "Build and deploy" section of .github/docs.yml. Or, what I did, add ENV["GKSwstype"] = "100" to docs/make.jl.