search

JuliaPolyhedra / Polyhedra.jl

Polyhedral Computation Interface
Other
172 stars 27 forks source link

Fix Interval setvrep and speed up redundancy removal #299

Closed blegat closed 2 years ago

blegat commented 2 years ago

When arguments where given, the redundancy removal or linearity detection was using the default implementation and not using the fact that intervals have no redundancy by construction. This was hitting another bug with setvrep! and resetvrep! which are not fixed as well. Closes https://github.com/JuliaPolyhedra/Polyhedra.jl/issues/298

codecov[bot] commented 2 years ago

Codecov Report

Merging #299 (e4befdc) into master (83192d1) will increase coverage by 0.11%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   89.00%   89.11%   +0.11%     
==========================================
  Files          37       37              
  Lines        3037     3051      +14     
==========================================
+ Hits         2703     2719      +16     
+ Misses        334      332       -2
Impacted Files Coverage Δ
src/defaultlibrary.jl 95.00% <100.00%> (+5.52%) :arrow_up:
src/interval.jl 97.82% <100.00%> (-1.40%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 83192d1...e4befdc. Read the comment docs.