JuliaPolyhedra / Polyhedra.jl

Polyhedral Computation Interface
Other
172 stars 27 forks source link

Fix planar hull on corner case #320

Closed blegat closed 1 year ago

blegat commented 1 year ago

Closes https://github.com/JuliaPolyhedra/Polyhedra.jl/issues/311

codecov[bot] commented 1 year ago

Codecov Report

Base: 88.79% // Head: 88.94% // Increases project coverage by +0.15% :tada:

Coverage data is based on head (1c6a68f) compared to base (1cc19df). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #320 +/- ## ========================================== + Coverage 88.79% 88.94% +0.15% ========================================== Files 37 37 Lines 3149 3157 +8 ========================================== + Hits 2796 2808 +12 + Misses 353 349 -4 ``` | [Impacted Files](https://codecov.io/gh/JuliaPolyhedra/Polyhedra.jl/pull/320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaPolyhedra) | Coverage Δ | | |---|---|---| | [src/planar.jl](https://codecov.io/gh/JuliaPolyhedra/Polyhedra.jl/pull/320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaPolyhedra#diff-c3JjL3BsYW5hci5qbA==) | `99.20% <100.00%> (+0.88%)` | :arrow_up: | | [src/recipe.jl](https://codecov.io/gh/JuliaPolyhedra/Polyhedra.jl/pull/320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaPolyhedra#diff-c3JjL3JlY2lwZS5qbA==) | `96.55% <100.00%> (+0.12%)` | :arrow_up: | | [src/repop.jl](https://codecov.io/gh/JuliaPolyhedra/Polyhedra.jl/pull/320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaPolyhedra#diff-c3JjL3JlcG9wLmps) | `95.17% <0.00%> (+0.68%)` | :arrow_up: | | [src/decompose.jl](https://codecov.io/gh/JuliaPolyhedra/Polyhedra.jl/pull/320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaPolyhedra#diff-c3JjL2RlY29tcG9zZS5qbA==) | `77.62% <0.00%> (+0.69%)` | :arrow_up: | | [src/linearity.jl](https://codecov.io/gh/JuliaPolyhedra/Polyhedra.jl/pull/320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaPolyhedra#diff-c3JjL2xpbmVhcml0eS5qbA==) | `91.53% <0.00%> (+0.76%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaPolyhedra). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaPolyhedra)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.