codecov[bot]
commented
7 months ago Codecov Report
Attention: 9 lines in your changes are missing coverage. Please review.
Comparison is base (
f582320) 88.92% compared to head (6332a57) 88.81%.
| Files | Patch % | Lines |
|---|---|---|
| src/iterators.jl | 86.66% | 2 Missing :warning: |
| src/redundancy.jl | 66.66% | 2 Missing :warning: |
| src/representation.jl | 60.00% | 2 Missing :warning: |
| src/aff.jl | 87.50% | 1 Missing :warning: |
| src/liftedrep.jl | 50.00% | 1 Missing :warning: |
| src/repop.jl | 91.66% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #332 +/- ## ========================================== - Coverage 88.92% 88.81% -0.11% ========================================== Files 37 37 Lines 3170 3175 +5 ========================================== + Hits 2819 2820 +1 - Misses 351 355 +4 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
As discussed in #328, I am opening a pr to address issues raised by Aqua.jl that could go into a breaking release of Polyhedra.jl. All of the changes are made are open to discussion, and I summarize them here:
removevredundancy,rmap,rrepsandsumpoints. A few ambiguities on*remain and I chose to ignore themhreps,points,hyperplanes,lines,rays, andhalfspacescould only enforce a parametrized coefficient type if they all accept at least one representation. Instead of adding an extra argument to all of the functions I usedpromoteto deduce the coefficient type. TheMeshtype had an uninitialized parameter that I initialized to an empty array by default.done*,start*andnext*were never defined, so I removed themFullDiminto aFullDimtype andtyped_fulldimfunction. An alternative is to turnFullDiminto a struct, likeStaticArrays.Size, but I found that more difficult to implement since it requires more than search+replace. Most likely this will break implementations of the Polyhedra.jl interface, e.g. CDDLib.jl.