search

JuliaPolyhedra / lrslib

[deprecated] Fork of LRS to help writing the LRSLib.jl Julia wrapper
GNU General Public License v2.0
1 stars 2 forks source link

Add `resetNashSolver()` to the public API #3

Closed bzinberg closed 3 years ago

bzinberg commented 3 years ago

Fixes https://github.com/JuliaPolyhedra/lrslib/issues/2.

Tested

Builds successfully on my machine.

blegat commented 3 years ago

Can you redirect the change to the branch of https://github.com/JuliaPolyhedra/lrslib/pull/4 ? We won't be making change for the old version of lrslib, let's focus on v7.1a. There the definition in the .h was removed and we need to add it back, see https://github.com/JuliaPolyhedra/LRSLib.jl/pull/41#discussion_r618159018

blegat commented 3 years ago

Probably even better is to add a function for modifying FirstTime and not defining the variable in .h.

bzinberg commented 3 years ago

Probably even better is to add a function for modifying FirstTime and not defining the variable in .h.

Responded to this in https://github.com/JuliaPolyhedra/LRSLib.jl/pull/41#discussion_r618515852

bzinberg commented 3 years ago

Can you redirect the change to the branch of #4 ? We won't be making change for the old version of lrslib, let's focus on v7.1a. There the definition in the .h was removed and we need to add it back, see JuliaPolyhedra/LRSLib.jl#41 (comment)

Absolutely. Thanks for working on the migration!

bzinberg commented 3 years ago

Can you redirect the change to the branch of #4 ?

Done, and changed the target branch of this PR accordingly.