Closed quinnj closed 6 years ago
@isdefined
isn't defined on 0.6, while both REQUIRE and Travis indicate that Conda master is meant to continue working on 0.6, so those lines may need to be guarded with if VERSION
How about
module DefaultDeps
if VERSION < v"0.7"
macro isdefined(x)
isdefined(x)
end
end
if isfile("deps.jl")
include("deps.jl")
end
if !(@isdefined ROOTENV)
const ROOTENV = abspath(dirname(@__FILE__), "usr")
end
if !(@isdefined MINICONDA_VERSION)
const MINICONDA_VERSION = "3"
end
end
I went with something similar; will merge if Travis is happy because no IPython on 1.0 is 😢.
You just need to use isdefined(@__MODULE__, ...)
instead. That is the Compat solution.
The remaining issue is that the Appveyor script uses julia -e 'versioninfo()
, which needs using InteractiveUtils
on 1.0. Should Conda switch to the Appveyor.jl version of the script?
Merging this as-is, so that people can use Conda.jl under 1.0. Fixing AppVeyor can be a separate PR.
Can we make a new release such that people can use IJulia on v1.0.
This fixes building Conda.jl on 1.0.