search

JuliaPy / Conda.jl

Conda managing Julia binary dependencies
Other
171 stars 57 forks source link

disable auto_update_conda #243

Closed szcf-weiya closed 10 months ago

szcf-weiya commented 1 year ago

The motivations come from #242 and #238, where the error "ResolvePackageNotFound: - conda==23.1.0" is thrown when conda automatically upgrades from 23.1.0 to 23.5.0.

Although I did not quite understand the real logic of the error, one simple workaround is to disable the auto-update of conda, i.e., fix its version.

On the other hand, since the package Conda.jl has already required to install the latest conda release,

https://github.com/JuliaPy/Conda.jl/blob/fe6c94c70609e6b6a8f853d72efc7d890df967e6/src/Conda.jl#L167-L179

I think the later update by auto_update_conda is just minor, like from 23.1.0 to 23.5.0, then disabling such minor aggressive updates should be reasonable. As a byproduct, it can save the upgrade time.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06% :tada:

Comparison is base (79c5487) 87.43% compared to head (fed4dbd) 87.50%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #243 +/- ## ========================================== + Coverage 87.43% 87.50% +0.06% ========================================== Files 1 1 Lines 207 208 +1 ========================================== + Hits 181 182 +1 Misses 26 26 ``` | [Files Changed](https://app.codecov.io/gh/JuliaPy/Conda.jl/pull/243?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaPy) | Coverage Δ | | |---|---|---| | [src/Conda.jl](https://app.codecov.io/gh/JuliaPy/Conda.jl/pull/243?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaPy#diff-c3JjL0NvbmRhLmps) | `87.50% <100.00%> (+0.06%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aplavin commented 10 months ago

Would be great to have a fix for this issue! Any problems with the PR? @stevengj @mkitti

mkitti commented 10 months ago

Why are the Windows tests failing?

szcf-weiya commented 10 months ago

I think it is just a simple edit, and should not be related to the platform.

How can we rerun the test? (I found a way, just update my forked repo). Because I noticed the near commits also failed on Windows.

image

szcf-weiya commented 10 months ago

Windows failed during the installation of miniconda, so I am guessing (tried to check the documentation https://docs.conda.io/projects/conda/en/latest/user-guide/install/windows.html but failed to find related documentation) whether the error is due to the provided PREFIX folder is not empty since I created the file condarc-julia.yaml in the package building step when (mini)conda was not yet installed.

So the updated version is to write the config file condarc-julia.yaml after installing (mini)conda.

stevengj commented 10 months ago

LGTM.

aplavin commented 10 months ago

Hm, I tested half a hour ago, and turns out that the underlying issue was already fixed somehow: PyCall, PyPlot, and other dependent packages install just fine on GitHub Actions. The same action failed just two weeks ago with the ResolvePackageNotFound error.

Not sure what changed, and where...

stevengj commented 10 months ago

Probably Conda fixed their packages in the meantime? But I still feel like it is good practice not to upgrade unless the user specifically requests Conda.update().