JuliaPy / Conda.jl

Conda managing Julia binary dependencies
Other
174 stars 57 forks source link

Issue warning and then ignore satisified_skip_solve on 32-bit windows #246

Closed mkitti closed 1 year ago

mkitti commented 1 year ago

Since conda has stopped being updated for 32-bit Windows and does not have --satisfied-skip-solve, issue a warning that it is not supported on that platform and then ignore the keyword on Conda.add.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.43 :warning:

Comparison is base (fe6c94c) 87.86% compared to head (058f7a2) 87.43%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #246 +/- ## ========================================== - Coverage 87.86% 87.43% -0.43% ========================================== Files 1 1 Lines 206 207 +1 ========================================== Hits 181 181 - Misses 25 26 +1 ``` | [Impacted Files](https://app.codecov.io/gh/JuliaPy/Conda.jl/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/Conda.jl](https://app.codecov.io/gh/JuliaPy/Conda.jl/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL0NvbmRhLmps) | `87.43% <50.00%> (-0.43%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

stevengj commented 1 year ago

LGTM.

mkitti commented 1 year ago

Merging expeditiously to resolve breakage then