JuliaPy / PyCall.jl

Package to call Python functions from the Julia language
MIT License
1.47k stars 190 forks source link

fix depwarn #1042

Closed ranocha closed 1 year ago

ranocha commented 1 year ago

This updates deprecated code introduced in https://github.com/JuliaPy/PyCall.jl/pull/1039. We found this since our tests using some operations from PyCall.jl with @test_nowarn failed.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -1.19 :warning:

Comparison is base (c12d6d7) 67.50% compared to head (c4288c8) 66.32%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1042 +/- ## ========================================== - Coverage 67.50% 66.32% -1.19% ========================================== Files 20 20 Lines 2025 2022 -3 ========================================== - Hits 1367 1341 -26 - Misses 658 681 +23 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `66.32% <100.00%> (-1.19%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/JuliaPy/PyCall.jl/pull/1042?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/PyCall.jl](https://app.codecov.io/gh/JuliaPy/PyCall.jl/pull/1042?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL1B5Q2FsbC5qbA==) | `66.35% <100.00%> (-1.55%)` | :arrow_down: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/JuliaPy/PyCall.jl/pull/1042/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.