search

JuliaPy / PyCall.jl

Package to call Python functions from the Julia language
MIT License
1.45k stars 186 forks source link

version stdlibs #1063

Closed stevengj closed 8 months ago

stevengj commented 8 months ago

this is now required for merging into the registry. I'm not 100% sure that this works with Julia 1.4 (may only work with 1.6?) but we'll see what CI says.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (69f9157) 67.19% compared to head (863ff00) 67.35%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1063 +/- ## ========================================== + Coverage 67.19% 67.35% +0.16% ========================================== Files 20 20 Lines 2024 2025 +1 ========================================== + Hits 1360 1364 +4 + Misses 664 661 -3 ``` | [Flag](https://app.codecov.io/gh/JuliaPy/PyCall.jl/pull/1063/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaPy) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/JuliaPy/PyCall.jl/pull/1063/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaPy) | `67.35% <ø> (+0.16%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaPy#carryforward-flags-in-the-pull-request-comment) to find out more. [see 4 files with indirect coverage changes](https://app.codecov.io/gh/JuliaPy/PyCall.jl/pull/1063/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaPy)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

simeonschaub commented 8 months ago

Ah, nice! Was just looking into this. Thanks!

stevengj commented 8 months ago

Looks like the package manager is able to resolve the new dependencies on Julia 1.4 and 1.5. (It's failing on a Conda import of pyzmq, which maybe can be resolved by switching to the six package similar to https://github.com/JuliaPy/Conda.jl/pull/209.)