search

JuliaPy / PyCall.jl

Package to call Python functions from the Julia language
MIT License
1.47k stars 190 forks source link

Use dir instead of getmembers #879

Closed sethaxen closed 3 years ago

sethaxen commented 3 years ago

Fixes #857 by using dir to get names of properties instead of getmembers, which also gets the properties themselves and therefore errors when properties are optional.

codecov-io commented 3 years ago

Codecov Report

Merging #879 (173542e) into master (ead312f) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #879      +/-   ##
==========================================
- Coverage   67.63%   67.61%   -0.02%     
==========================================
  Files          20       20              
  Lines        1965     1967       +2     
==========================================
+ Hits         1329     1330       +1     
- Misses        636      637       +1
Flag Coverage Δ
unittests 67.61% <100.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/PyCall.jl 69.75% <100.00%> (+0.18%) :arrow_up:
src/conversions.jl 63.13% <0.00%> (-0.26%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ead312f...173542e. Read the comment docs.

sethaxen commented 3 years ago

@stevengj can a new release be tagged as well?

sethaxen commented 3 years ago

@stevengj can you tag a new release? One of my packages needs this fix.