search

JuliaPy / PyCall.jl

Package to call Python functions from the Julia language
MIT License
1.47k stars 187 forks source link

rm arch checks in build script #906

Closed stevengj closed 2 years ago

stevengj commented 3 years ago

Closes #806.

codecov-commenter commented 3 years ago

Codecov Report

Merging #906 (4474b71) into master (8a98fb4) will increase coverage by 0.21%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #906      +/-   ##
==========================================
+ Coverage   68.03%   68.24%   +0.21%     
==========================================
  Files          20       20              
  Lines        1980     2012      +32     
==========================================
+ Hits         1347     1373      +26     
- Misses        633      639       +6
Flag Coverage Δ
unittests 68.24% <ø> (+0.21%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pydates.jl 93.10% <0.00%> (-3.27%) :arrow_down:
src/pybuffer.jl 61.11% <0.00%> (-0.80%) :arrow_down:
src/exception.jl 60.74% <0.00%> (-0.80%) :arrow_down:
src/pyarray.jl 70.00% <0.00%> (-0.55%) :arrow_down:
src/pyeval.jl 70.47% <0.00%> (-0.12%) :arrow_down:
src/gui.jl 0.00% <0.00%> (ø)
src/conversions.jl 63.32% <0.00%> (+<0.01%) :arrow_up:
src/pyclass.jl 96.72% <0.00%> (+0.05%) :arrow_up:
src/pyfncall.jl 97.36% <0.00%> (+0.14%) :arrow_up:
src/io.jl 83.33% <0.00%> (+0.23%) :arrow_up:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8a98fb4...4474b71. Read the comment docs.

stevengj commented 3 years ago

I think the test failures are unrelated; CI seems to have bitrotted.

omus commented 3 years ago

With the changes in this PR on aarch64 I no longer see the build failure but get

$ PYTHON="" julia --project
(PyCall) pkg> build PyCall
    Building Conda ─→ `~/.julia/scratchspaces/44cfe95a-1eb2-52ea-b672-e2afdf69b78f/299304989a5e6473d985212c28928899c74e9421/build.log`
    Building PyCall → `~/.julia/dev/PyCall/deps/build.log`

julia> using PyCall
ImportError: No module named site
stevengj commented 3 years ago

Is it using the Conda Python? Presumably it is some kind of PYTHONPATH problem?