Closed PallHaraldsson closed 2 years ago
Hopefully that's a correct change assuming the build system had Python 3.10 (which is out), but it seems it doesn't. I just overwrote, not sure we need to also test older versions (or Julia 1.5 or older).
One question, should PyCall work in exceptional cases? All libraries should work, and I see, thrown exceptions, not caught propagate to Julia. At least FYI for upcoming Python 3.11:
PEP 654 -- Exception Groups and except* https://www.python.org/dev/peps/pep-0654/
I don't think the exception group needs an explicit support in PyCall?
FYI, we don't need to do this anymore after #932 and #933.
Codecov Report
68.02% <ø> (-0.01%)
Flags with carried forward coverage won't be shown. Click here to find out more.
93.10% <0.00%> (-3.27%)
61.11% <0.00%> (-0.80%)
60.74% <0.00%> (-0.80%)
70.00% <0.00%> (-0.55%)
70.47% <0.00%> (-0.12%)
0.00% <0.00%> (ø)
63.32% <0.00%> (+<0.01%)
96.72% <0.00%> (+0.05%)
97.36% <0.00%> (+0.14%)
83.33% <0.00%> (+0.23%)
Continue to review full report at Codecov.