search

JuliaPy / PyCall.jl

Package to call Python functions from the Julia language
MIT License
1.47k stars 187 forks source link

Test Python 3.10 (on Julia 1.6) #928

Closed PallHaraldsson closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #928 (d2cf489) into master (8a98fb4) will decrease coverage by 0.00%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #928      +/-   ##
==========================================
- Coverage   68.03%   68.02%   -0.01%     
==========================================
  Files          20       20              
  Lines        1980     2033      +53     
==========================================
+ Hits         1347     1383      +36     
- Misses        633      650      +17
Flag Coverage Δ
unittests 68.02% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pydates.jl 93.10% <0.00%> (-3.27%) :arrow_down:
src/pybuffer.jl 61.11% <0.00%> (-0.80%) :arrow_down:
src/exception.jl 60.74% <0.00%> (-0.80%) :arrow_down:
src/pyarray.jl 70.00% <0.00%> (-0.55%) :arrow_down:
src/pyeval.jl 70.47% <0.00%> (-0.12%) :arrow_down:
src/gui.jl 0.00% <0.00%> (ø)
src/conversions.jl 63.32% <0.00%> (+<0.01%) :arrow_up:
src/pyclass.jl 96.72% <0.00%> (+0.05%) :arrow_up:
src/pyfncall.jl 97.36% <0.00%> (+0.14%) :arrow_up:
src/io.jl 83.33% <0.00%> (+0.23%) :arrow_up:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8a98fb4...d2cf489. Read the comment docs.

PallHaraldsson commented 2 years ago

Hopefully that's a correct change assuming the build system had Python 3.10 (which is out), but it seems it doesn't. I just overwrote, not sure we need to also test older versions (or Julia 1.5 or older).

One question, should PyCall work in exceptional cases? All libraries should work, and I see, thrown exceptions, not caught propagate to Julia. At least FYI for upcoming Python 3.11:

PEP 654 -- Exception Groups and except* https://www.python.org/dev/peps/pep-0654/

tkf commented 2 years ago

I don't think the exception group needs an explicit support in PyCall?

FYI, we don't need to do this anymore after #932 and #933.