JuliaPy / PyCall.jl

Package to call Python functions from the Julia language
MIT License
1.46k stars 187 forks source link

Avoid deprecated BLAS.vendor() in MKL conflict check #950

Closed dnadlinger closed 2 years ago

dnadlinger commented 2 years ago

Patch as suggested by Carsten Bauer in #922.


As discussed in #922, the new BLAS trampoline magic might allow us to avoid this issue altogether, but this is nontrivial, as it would involve loading MKL in two different configurations even if it did work (the libtrampoline author wasn't sure about that either). For now, this avoids the annoying warning every time PyCall is loaded.

codecov-commenter commented 2 years ago

Codecov Report

Merging #950 (4938dae) into master (e3e3008) will decrease coverage by 0.00%. The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #950      +/-   ##
==========================================
- Coverage   68.33%   68.33%   -0.01%     
==========================================
  Files          20       20              
  Lines        2018     2021       +3     
==========================================
+ Hits         1379     1381       +2     
- Misses        639      640       +1     
Flag Coverage Δ
unittests 68.33% <75.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/numpy.jl 75.30% <75.00%> (-0.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e3e3008...4938dae. Read the comment docs.

MilesCranmer commented 2 years ago

Can this be merged?

bkamins commented 2 years ago

bump

tkf commented 2 years ago

Registering: https://github.com/JuliaRegistries/General/pull/55870

MilesCranmer commented 2 years ago

Thanks!