JuliaPy / PyPlot.jl

Plotting for Julia based on matplotlib.pyplot
https://github.com/JuliaPy/PyPlot.jl
MIT License
475 stars 87 forks source link

`using PyPlot` crashes package precompilation on Julia v1.10.0-beta1 #572

Closed pszufe closed 1 year ago

pszufe commented 1 year ago

[this is also cross-post on PyCall https://github.com/JuliaPy/PyCall.jl/issues/1047]

Consider the following package:

(@v1.10) pkg> generate Test1
  Generating  project Test1:
    Test1\Project.toml
    Test1\src\Test1.jl

Where PyPlot has been added via Pkg.add to dependencies and Test1.jl contains

module Test1
using PyPlot
end 

In that case using Test1 (after Pkg.activate) goes into an endless loop (I pressed Ctrl+C at some point):

julia> using Test1
Precompiling Test1
  Progress [>                                        ]  0/1
  ◑ Test1 Waiting for background task / IO / timer. Interrupt to inspect
 Interrupted: Exiting precompilation...

  1 dependency had warnings during precompilation:
┌ Test1 [ddca8587-cad1-46e2-86b4-b726afea1d60]
│  [pid 7156] waiting for IO to finish:
│   TYPE[FD/PID]       @UV_HANDLE_T->DATA
│   timer              @00000228c312eca0->00000228bf815db0
└

When this is run on a fresh Julia installation it seemed that it additionally tries to install matplotlib via Conda (regardless of the fact that it is already present due to PyPlot being built earlier).

Tested on Julia 1.10 beta1, Windows11 as well Linux by myself and @giordano

MilesCranmer commented 1 year ago

Probably the same as discussed on this issue: https://github.com/comonicon/Comonicon.jl/issues/249

i.e., this block: https://github.com/JuliaPy/PyPlot.jl/blob/343430ac4f822a84a5e19bf5dabf7a846b171c9b/src/init.jl#L171-L209 is opening I/O resources and not closing them, which is not allowed on 1.10

See https://github.com/JuliaPlots/PlotlyKaleido.jl/pull/6 for an example of a fix. I guess PyPlot.jl will have to do something similar

timholy commented 1 year ago

This was already fixed in #565, we just need a new release. (Last release was in March, before that PR was merged.)

MilesCranmer commented 1 year ago

Ah, that explains it :)

stevengj commented 1 year ago

Closed by https://github.com/JuliaRegistries/General/pull/89626