Closed brian-dellabetta closed 11 months ago
Merging #333 (1421a06) into main (e374e25) will decrease coverage by
0.01%
. The diff coverage is100.00%
.:exclamation: Current head 1421a06 differs from pull request most recent head ebf8919. Consider uploading reports for the commit ebf8919 to get more accurate results
@@ Coverage Diff @@
## main #333 +/- ##
==========================================
- Coverage 41.50% 41.50% -0.01%
==========================================
Files 76 76
Lines 4652 4653 +1
==========================================
Hits 1931 1931
- Misses 2721 2722 +1
Impacted Files | Coverage Δ | |
---|---|---|
pysrc/juliacall/__init__.py | 71.22% <100.00%> (ø) |
Thank you. Could you also update the FAQ.md please with better advice for multithreading?
@cjdoris sure thing, just pushed and referenced the discussion thread.
@cjdoris I also replied to corresponding issue here. I think users would want signal handling on by default, should we default to yes
? It's a behavioral change from previous versions, but almost always wanted
Thanks! Please open a separate issue/PR to change the default - AFAIR making it yes by default has undesirable side-effects on Python.
Hi @cjdoris , this PR is to allow a user to configure what is passed to
julia --handle-signals=<yes,no>
. I have just updated it to be in line with all the other CONFIG params, defaulting tono
to retain backwards compatibility.Following discussion thread starting here, I have found that this is much more robust and clean way to allow for multi-threaded julia code than my previous workaround.
Related to #219 Related to #298 Related to #330