search

JuliaPy / PythonCall.jl

Python and Julia in harmony.
https://juliapy.github.io/PythonCall.jl/stable/
MIT License
720 stars 61 forks source link

Update `Documenter -> v1` #372

Closed pedromxavier closed 9 months ago

pedromxavier commented 9 months ago

This PR aims to update the Documenter.jl version to v1, thus closes #359.

The DocsNode API changed significantly in v1, so we might need some help from @mortenpi to restore the previous functionality.

pedromxavier commented 9 months ago

Documentation is currently building but the juliacall dropdowns are not working properly.

pedromxavier commented 9 months ago

Dropdown is now expanding but there's still a annoying link issue that scrolls up upon clicking.

pedromxavier commented 9 months ago

Apparently, this hack does the trick.

pedromxavier commented 9 months ago

@cjdoris, please label this PR as 'documentation'. I've added an action trigger to generate previews for PR labeled this way.

pedromxavier commented 9 months ago

The preview was not produced because the PR didn't originate in JuliaPy/PythonCall. Nevertheless, it should work for future PRs. I think this PR is ready for review.

cjdoris commented 9 months ago

Just built the docs locally - they look great. Thanks for this!