JuliaPy / PythonCall.jl

Python and Julia in harmony.
https://juliapy.github.io/PythonCall.jl/stable/
MIT License
776 stars 63 forks source link

Expand testing #448

Open MilesCranmer opened 8 months ago

MilesCranmer commented 8 months ago

Currently the test suite is very small, most notably the juliacall suite: https://github.com/JuliaPy/PythonCall.jl/blob/main/pytest/test_all.py which is only 19 lines long. I am very worried about reliability issues from this and whether this might result in regressions.

I think expanding the test suite should be a priority, especially on the juliacall side, before new features are worked on.

Here are some suggestions. Feel free to check any that are already done or add more

cjdoris commented 8 months ago

Absolutely, I've been holding off making another release because I recently did a big refactor and want to get test coverage up so I can trust I didn't break anything.

Indeed the test suite of JuliaCall is short - but then so is JuliaCall itself. My priority has been to get the coverage for PythonCall up, because that covers most of JuliaCall too.

Your list looks really good. I don't think it's especially needed to test the same code twice (from Julia and from Python) so most of the points in the first group should probably done in the PythonCall tests in Julia, leaving the tests in Python to the parts of JuliaCall actually written in Python.

Integration tests sound great.

MilesCranmer commented 7 months ago

Sounds good to me!