Hot fix for #479 - Githubissues

JuliaPy / PythonCall.jl

Python and Julia in harmony.

https://juliapy.github.io/PythonCall.jl/stable/

MIT License

715 stars 61 forks source link

Hot fix for #479 #480

Closed lassepe closed 3 months ago

lassepe commented 3 months ago

Resolves #479

lassepe commented 3 months ago

This symptomatically fixes the issues described in #479. I am not sufficiently familiar with meta programming and macro hygiene to tell if this is should be fixed in MacroTools instead though.

Maybe some of the MacroTools.jl maintainers (such as @cstjean) can chime in here?

xref: https://github.com/FluxML/MacroTools.jl/issues/30

cjdoris commented 3 months ago

Awesome, thanks for the fix - and the test! Will make a new release shortly.

cstjean commented 3 months ago

Yeah, I see it as a MacroTools bug, as posted in https://github.com/FluxML/MacroTools.jl/issues/30. I would be happy to merge a MacroTools PR that fixes that. It's probably sufficient to turn MacroTools to $MacroTools in the macro expansion.