search

JuliaPy / PythonCall.jl

Python and Julia in harmony.
https://juliapy.github.io/PythonCall.jl/stable/
MIT License
715 stars 61 forks source link

PythonCall.jl 0.9.19 and 0.9.20 seem broken on julia-nightly on GH actions #513

Open kshyatt-aws opened 4 days ago

kshyatt-aws commented 4 days ago

Affects: PythonCall

Describe the bug

When running the tests for BraketSimulator.jl, which use PythonCall.jl, on GitHub actions using julia-nightly, I get the following error:

LoadError: UndefVarError: `pyconvert` not defined in `PythonCall`

Even though as far as I can tell, PythonCall.jl does export this function. It's only occuring on GH actions, I can't reproduce it locally with a checkout of Julialang master.

Please include the steps required to reproduce the bug. This should include not just code but all the steps required to reproduce the bug

Your system Please provide detailed information about your system:

Additional context Add any other context about the problem here.

kshyatt-aws commented 4 days ago

OK, was able to repro finally using https://github.com/nektos/act. Developing PythonCall.jl doesn't seem to help.

kshyatt-aws commented 3 days ago

Now can repro locally on my laptop with a latest checkout and make of Julia master + a fresh Pkg.instantiate. Looks like some recent Julia commit broke PythonCall.jl?

kshyatt-aws commented 3 days ago

Some fun with git bisect reveals the offending JuliaLang/julia commit causing this is https://github.com/JuliaLang/julia/commit/71fa11f0427fc66f2328cddbba865852fa47e0f1

fatteneder commented 2 days ago

Some fun with git bisect reveals the offending JuliaLang/julia commit causing this is JuliaLang/julia@71fa11f

This issue persists when I revert that commit on master.

But I can also confirm that the issue appears on that commit, and vanishes on its parent 4a65772.