search

JuliaPy / PythonPlot.jl

Plotting for Julia based on matplotlib.pyplot
MIT License
74 stars 8 forks source link

fix bugs with pyexists and qt path #34

Closed jjstickel closed 4 months ago

jjstickel commented 10 months ago

On my system (MacOS with macports-installed julia and python), PythonPlot was not picking up an appropriate gui backend. It took some sleuthing to determine why, but I discovered that pyimport("importlib") would sometimes not include util as an attribute. This PR fixes that problem, and also adds output of the error in the gui-detection try block to help with any future bugs that might arise there.

I also include in this PR a change to comment out fixqtpath() as it does not seem to work properly, as also reported in #17. I have not spent time chasing this one down. This change enables Qt5 backend on my system, even without specifying ENV["QT_PLUGIN_PATH"].

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@fe588f4). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #34 +/- ## ======================================= Coverage ? 19.51% ======================================= Files ? 5 Lines ? 451 Branches ? 0 ======================================= Hits ? 88 Misses ? 363 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ufechner7 commented 7 months ago

Any chance to get this merged, or what is missing?

jjstickel commented 4 months ago

Bump. I was hoping to share code with colleagues that uses PythonPlot, and it would be easier if this is merged.