search

JuliaPy / SymPy.jl

Julia interface to SymPy via PyCall
http://juliapy.github.io/SymPy.jl/
MIT License
268 stars 62 forks source link

Correct subtyping #486

Closed tomaklutfu closed 1 year ago

tomaklutfu commented 1 year ago

Fixes #485 warning and dangling subtyping.

codecov-commenter commented 1 year ago

Codecov Report

Base: 55.96% // Head: 55.98% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (d91e838) compared to base (b6316e4). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #486 +/- ## ========================================== + Coverage 55.96% 55.98% +0.01% ========================================== Files 19 19 Lines 1181 1204 +23 ========================================== + Hits 661 674 +13 - Misses 520 530 +10 ``` | [Impacted Files](https://codecov.io/gh/JuliaPy/SymPy.jl/pull/486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/utils.jl](https://codecov.io/gh/JuliaPy/SymPy.jl/pull/486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3V0aWxzLmps) | `82.92% <100.00%> (+1.03%)` | :arrow_up: | | [src/constructors.jl](https://codecov.io/gh/JuliaPy/SymPy.jl/pull/486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2NvbnN0cnVjdG9ycy5qbA==) | `86.79% <0.00%> (-1.67%)` | :arrow_down: | | [src/symfunction.jl](https://codecov.io/gh/JuliaPy/SymPy.jl/pull/486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3N5bWZ1bmN0aW9uLmps) | `68.00% <0.00%> (-1.39%)` | :arrow_down: | | [src/SymPy.jl](https://codecov.io/gh/JuliaPy/SymPy.jl/pull/486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL1N5bVB5Lmps) | `62.00% <0.00%> (-1.27%)` | :arrow_down: | | [src/types.jl](https://codecov.io/gh/JuliaPy/SymPy.jl/pull/486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3R5cGVzLmps) | `34.69% <0.00%> (-0.73%)` | :arrow_down: | | [src/assumptions.jl](https://codecov.io/gh/JuliaPy/SymPy.jl/pull/486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2Fzc3VtcHRpb25zLmps) | `18.40% <0.00%> (-0.41%)` | :arrow_down: | | [src/lambdify.jl](https://codecov.io/gh/JuliaPy/SymPy.jl/pull/486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2xhbWJkaWZ5Lmps) | `96.92% <0.00%> (+0.04%)` | :arrow_up: | | [src/numbers.jl](https://codecov.io/gh/JuliaPy/SymPy.jl/pull/486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL251bWJlcnMuamw=) | `60.00% <0.00%> (+0.31%)` | :arrow_up: | | [src/mathfuns.jl](https://codecov.io/gh/JuliaPy/SymPy.jl/pull/486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL21hdGhmdW5zLmps) | `70.00% <0.00%> (+0.33%)` | :arrow_up: | | [src/matrix.jl](https://codecov.io/gh/JuliaPy/SymPy.jl/pull/486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL21hdHJpeC5qbA==) | `66.66% <0.00%> (+0.41%)` | :arrow_up: | | ... and [2 more](https://codecov.io/gh/JuliaPy/SymPy.jl/pull/486/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jverzani commented 1 year ago

Thanks. Looks like there are some unrelated errors that need adjustment.