search

JuliaQuantumControl / Krotov.jl

Julia implementation of Krotov's method for quantum optimal control
https://juliaquantumcontrol.github.io/Krotov.jl
MIT License
7 stars 2 forks source link

Remove `PulseParametrization`, use `ParametrizedAmplitude` instead. #21

Closed goerz closed 2 years ago

goerz commented 2 years ago

This removes the old PulseParametrization and its initializers SquareParametrization, TanhParametrization, TanhSqParametrization, LogisticParametrization, LogisticSqParametrization.

These have been moved to QuantumControlBase in a modified form, see https://github.com/JuliaQuantumControl/QuantumControlBase.jl/pull/46

The parametrization example is updated to use the the new ParametrizedAmplitude.

codecov-commenter commented 2 years ago

Codecov Report

Merging #21 (369a20e) into master (203b640) will decrease coverage by 0.75%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   88.67%   87.92%   -0.76%     
==========================================
  Files           5        4       -1     
  Lines         265      207      -58     
==========================================
- Hits          235      182      -53     
+ Misses         30       25       -5
Impacted Files Coverage Δ
src/Krotov.jl 50.00% <ø> (ø)
src/workspace.jl 77.27% <ø> (-0.99%) :arrow_down:
src/optimize.jl 92.08% <100.00%> (+2.82%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.