JuliaQuantumControl / QuantumControl.jl

Julia Framework for Quantum Dynamics and Control
https://juliaquantumcontrol.github.io/QuantumControl.jl/
MIT License
49 stars 7 forks source link

Make grad_J_a act not-in-place #76

Closed goerz closed 1 week ago

goerz commented 1 week ago

This is much easier for a user to deal with. It really shouldn't make any difference for performance, and in fact, may enhance it (the old implementation was using copyto!). In situations where it would make a difference, like for insanely large pulses, there's always the option of using a non-allocating functor.