search

JuliaQuantumControl / QuantumPropagators.jl

Propagators for Quantum Dynamics and Optimal Control
https://juliaquantumcontrol.github.io/QuantumPropagators.jl/
MIT License
16 stars 4 forks source link

Allow Modules as propagation method, remove `:auto` #59

Closed goerz closed 7 months ago

goerz commented 7 months ago

In preparation for allowing for ODE solvers via an optional dependency, we now allow (and encourage) passing modules as a propagation method.

Also, the method now must be explicitly specified, :auto is no longer an option. The heuristics for choosing a propagation methods are brittle, and it's probably a good idea for people to think about which method they should use anyway.

With optional dependencies (ODE) being added, automatically choosing a method becomes even weirder.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (acb187c) 88.2% compared to head (9932d73) 88.4%.

:exclamation: Current head 9932d73 differs from pull request most recent head d421db0. Consider uploading reports for the commit d421db0 to get more accurate results

Files Patch % Lines
src/propagator.jl 62.5% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #59 +/- ## ======================================== + Coverage 88.2% 88.4% +0.2% ======================================== Files 26 26 Lines 1821 1788 -33 ======================================== - Hits 1605 1579 -26 + Misses 216 209 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

goerz commented 7 months ago

Not sure why this is marked as "closed": it was properly merged into master in d421db0