search

JuliaRandom / Random123.jl

Julia implementation of Random123.
http://juliarandom.github.io/RandomNumbers.jl/stable/man/random123/
Other
18 stars 5 forks source link

Remove `deps` folder and check AES-NI in `__init__()`. #11

Closed sunoru closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #11 (95991e6) into master (840c556) will decrease coverage by 0.41%. The diff coverage is 83.33%.

:exclamation: Current head 95991e6 differs from pull request most recent head ef42ab2. Consider uploading reports for the commit ef42ab2 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   98.54%   98.12%   -0.42%     
==========================================
  Files           7        8       +1     
  Lines         822      853      +31     
==========================================
+ Hits          810      837      +27     
- Misses         12       16       +4
Impacted Files Coverage Δ
src/aesni/aesni.jl 98.95% <ø> (ø)
src/aesni/ars.jl 98.33% <ø> (ø)
src/aesni/common.jl 85.71% <ø> (ø)
src/common.jl 93.90% <ø> (+0.31%) :arrow_up:
src/Random123.jl 83.33% <81.81%> (-16.67%) :arrow_down:
src/aesni/module.jl 100.00% <100.00%> (ø)
src/threefry.jl 99.54% <0.00%> (+<0.01%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 840c556...ef42ab2. Read the comment docs.

sunoru commented 2 years ago

Looks good now...

vchuravy commented 2 years ago

This broke downstream compilation of packages: See https://github.com/JuliaGPU/CUDA.jl/issues/1422

sunoru commented 2 years ago

Ah I missed this comment! I'll look into it later