JuliaRandom / RandomNumbers.jl

Random Number Generators for the Julia Language.
https://juliarandom.github.io/RandomNumbers.jl/stable
Other
97 stars 23 forks source link

1.0 fixes #42

Closed currymj closed 6 years ago

currymj commented 6 years ago

is_bsd no longer exists on 1.0, despite not having a depwarn. Replaced with Sys.isbsd(). Likewise for is_apple.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 53c72cdd0c9f8b81277233dbac4533acf592e977 on currymj:1.0-isbsd-fix into f2b1250a0f8416b4b2d2c486eddd131c8d5fed9a on sunoru:master.

jleugeri commented 6 years ago

The tests seem to fail with

LoadError: LoadError: ArgumentError: Package Test not found in current path:

  • Run Pkg.add("Test") to install the Test package.

which doesn't seem very helpful :neutral_face:

currymj commented 6 years ago

Yes, I have no idea what's causing that problem. I have at least gotten using RandomNumbers to work just by doing a big find-and-replace of Random.srand with Random.seed!, but obviously tests need to be run.

currymj commented 6 years ago

so i manually ran add Test in the Pkg repl, and for some reason that allowed me to run tests locally. they all still pass, at least.

currymj commented 6 years ago

Tests now succeed on Mac and Linux; on Windows it seems like some kind of issue with the test script.

Note that I literally did a project-wide find-and-replace of srand to seed!. It doesn't seem like that should pose a problem but I didn't look at every single one.

codecov-io commented 6 years ago

Codecov Report

Merging #42 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #42   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines         547    455   -92     
=====================================
- Hits          547    455   -92
Impacted Files Coverage Δ
src/Random123/common.jl 100% <ø> (ø) :arrow_up:
src/Xorshifts/xorshift64.jl 100% <ø> (ø) :arrow_up:
src/Xorshifts/xoroshiro128.jl 100% <ø> (ø) :arrow_up:
src/wrapped_rng.jl 100% <ø> (ø) :arrow_up:
src/PCG/bases.jl 100% <ø> (ø) :arrow_up:
src/Xorshifts/xorshift128.jl 100% <ø> (ø) :arrow_up:
src/Random123/aesni.jl 100% <ø> (ø) :arrow_up:
src/MersenneTwisters/bases.jl 100% <100%> (ø) :arrow_up:
src/Random123/threefry.jl 100% <100%> (ø) :arrow_up:
src/Xorshifts/xorshift1024.jl 100% <100%> (ø) :arrow_up:
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f2b1250...53c72cd. Read the comment docs.

currymj commented 6 years ago

Right now the only failing test is win32, and seemingly for build-script-related reasons. win64, Mac, and Linux pass.

ChrisRackauckas commented 6 years ago

bump?

currymj commented 6 years ago

@sunoru pinging you with the at sign in case you have email notifications turned off for opened PRs

ChrisRackauckas commented 6 years ago

bump

sunoru commented 6 years ago

Thanks. I will bump the version by myself.