Closed currymj closed 6 years ago
The tests seem to fail with
LoadError: LoadError: ArgumentError: Package Test not found in current path:
- Run
Pkg.add("Test")
to install the Test package.
which doesn't seem very helpful :neutral_face:
Yes, I have no idea what's causing that problem. I have at least gotten using RandomNumbers
to work just by doing a big find-and-replace of Random.srand
with Random.seed!
, but obviously tests need to be run.
so i manually ran add Test
in the Pkg repl, and for some reason that allowed me to run tests locally. they all still pass, at least.
Tests now succeed on Mac and Linux; on Windows it seems like some kind of issue with the test script.
Note that I literally did a project-wide find-and-replace of srand
to seed!
. It doesn't seem like that should pose a problem but I didn't look at every single one.
Merging #42 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #42 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 16 16
Lines 547 455 -92
=====================================
- Hits 547 455 -92
Impacted Files | Coverage Δ | |
---|---|---|
src/Random123/common.jl | 100% <ø> (ø) |
:arrow_up: |
src/Xorshifts/xorshift64.jl | 100% <ø> (ø) |
:arrow_up: |
src/Xorshifts/xoroshiro128.jl | 100% <ø> (ø) |
:arrow_up: |
src/wrapped_rng.jl | 100% <ø> (ø) |
:arrow_up: |
src/PCG/bases.jl | 100% <ø> (ø) |
:arrow_up: |
src/Xorshifts/xorshift128.jl | 100% <ø> (ø) |
:arrow_up: |
src/Random123/aesni.jl | 100% <ø> (ø) |
:arrow_up: |
src/MersenneTwisters/bases.jl | 100% <100%> (ø) |
:arrow_up: |
src/Random123/threefry.jl | 100% <100%> (ø) |
:arrow_up: |
src/Xorshifts/xorshift1024.jl | 100% <100%> (ø) |
:arrow_up: |
... and 19 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f2b1250...53c72cd. Read the comment docs.
Right now the only failing test is win32, and seemingly for build-script-related reasons. win64, Mac, and Linux pass.
bump?
@sunoru pinging you with the at sign in case you have email notifications turned off for opened PRs
bump
Thanks. I will bump the version by myself.
is_bsd no longer exists on 1.0, despite not having a depwarn. Replaced with
Sys.isbsd()
. Likewise foris_apple
.