search

JuliaRandom / RandomNumbers.jl

Random Number Generators for the Julia Language.
https://juliarandom.github.io/RandomNumbers.jl/stable
Other
97 stars 23 forks source link

0.5 is no longer current #51

Closed PallHaraldsson closed 5 years ago

sunoru commented 5 years ago

Yes, thanks!

PallHaraldsson commented 5 years ago

I had an issue about changing the default for 1.0 but it was too late.

I believe the RNG was unchanged in 0.6; and then at least from 0.6 to 0.7/1.0.

sunoru commented 5 years ago

Yes.. And I was also too busy to follow the discussion about changing the default RNG.

PallHaraldsson commented 5 years ago

That was fast... or me slow writing explaining before you merged). At least 0.5 is no longer current. As I said, I assume the RNG hasn't changed.

sunoru commented 5 years ago

You are right. It hasn't been changed (still the DSFMT). I forgot to update the docs.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-1.5%) to 41.597% when pulling b2569c8f5b376d865475bd513d48787447326a98 on PallHaraldsson:patch-1 into f2ec9b2559d4db9794dc4cc5e3c9b4a8e07d8a46 on sunoru:master.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-1.5%) to 41.597% when pulling b2569c8f5b376d865475bd513d48787447326a98 on PallHaraldsson:patch-1 into f2ec9b2559d4db9794dc4cc5e3c9b4a8e07d8a46 on sunoru:master.

PallHaraldsson commented 5 years ago

Should it say "up to and including current 1.0" or even say 1.0.2 that I now see is out?

sunoru commented 5 years ago

Maybe it's better. I think the current expression is OK.

PallHaraldsson commented 5 years ago

"The Mersenne Twister[^1] is so far the most widely used PRNG."

Did you mean to say "by far"? In case I make the change about, would this one be also ok?

sunoru commented 5 years ago

What do you mean by "by far"? I'm sorry for not understanding English well..

PallHaraldsson commented 5 years ago

"so far" = up to now. "by far" = way more [popular], not just "the most widely used PRNG". "so far" could mean, not much more popular and possibly not for much longer. happens to be most used

I think you're also not wring this for Julia software, where MT happens to be most used, but I guess you're trying to change that. :)

sunoru commented 5 years ago

Thank you :) Actually I wanted to say "up to now" in that sentence, for I'm hoping there can be something such as xoroshiro to be the new most used one.