jakobnissen commented 5 years ago

Changed the implementation of the xorshift_rotl methods. They now compile to something closer to a single bit rotate CPU instruction.

codecov-io commented 5 years ago

Codecov Report

Merging #61 into master will increase coverage by 0.21%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   85.71%   85.93%   +0.21%     
==========================================
  Files          21       21              
  Lines         462      462              
==========================================
+ Hits          396      397       +1     
+ Misses         66       65       -1

Impacted Files	Coverage Δ
src/Xorshifts/common.jl	`100% <100%> (ø)`	:arrow_up:
src/common.jl	`100% <0%> (+11.11%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 087acf3...38b9ed6. Read the comment docs.

coveralls commented 5 years ago

Coverage increased (+0.3%) to 84.257% when pulling 38b9ed69de61f20f5cf26d36b3175ec5f056c2ab on jakobnissen:master into 087acf323a6591605ee95e61092f430a986b02ae on sunoru:master.

coveralls commented 5 years ago

Coverage increased (+0.3%) to 84.257% when pulling 38b9ed69de61f20f5cf26d36b3175ec5f056c2ab on jakobnissen:master into 087acf323a6591605ee95e61092f430a986b02ae on sunoru:master.

coveralls commented 5 years ago

Coverage increased (+0.3%) to 84.257% when pulling 38b9ed69de61f20f5cf26d36b3175ec5f056c2ab on jakobnissen:master into 087acf323a6591605ee95e61092f430a986b02ae on sunoru:master.

sunoru commented 5 years ago

Thanks a lot! I just checked it out and ran some benchmarks myself, and you are right.

JuliaRandom / RandomNumbers.jl

Added efficient bit rotate functions #61

Codecov Report