Open schillic opened 5 years ago
We have different keyword arguments to remove redundancies in different methods: prune, apply_convex_hull, and remove_zero_generators. I suggest that we use prune everywhere because it is short and applies in all cases.
prune
apply_convex_hull
remove_zero_generators
So is the inconsistency with vertices_list below alright? Here you need to choose the argument name based on the types. I find that impractical.
vertices_list
https://github.com/JuliaReach/LazySets.jl/blob/054f1d2aac78e074595855b25fd35c3b789c7ff2/src/LazyOperations/LinearMap.jl#L392
https://github.com/JuliaReach/LazySets.jl/blob/054f1d2aac78e074595855b25fd35c3b789c7ff2/src/Interfaces/AbstractZonotope.jl#L358-L359
We have different keyword arguments to remove redundancies in different methods:
prune
,apply_convex_hull
, andremove_zero_generators
. I suggest that we useprune
everywhere because it is short and applies in all cases.