search

JuliaReach / LazySets.jl

Scalable symbolic-numeric set computations in Julia
https://juliareach.github.io/LazySets.jl/
Other
226 stars 32 forks source link

Unify keyword arguments to remove redundancies #1660

Open schillic opened 5 years ago

schillic commented 5 years ago

We have different keyword arguments to remove redundancies in different methods: prune, apply_convex_hull, and remove_zero_generators. I suggest that we use prune everywhere because it is short and applies in all cases.

schillic commented 4 years ago

So is the inconsistency with vertices_list below alright? Here you need to choose the argument name based on the types. I find that impractical.

https://github.com/JuliaReach/LazySets.jl/blob/054f1d2aac78e074595855b25fd35c3b789c7ff2/src/LazyOperations/LinearMap.jl#L392

https://github.com/JuliaReach/LazySets.jl/blob/054f1d2aac78e074595855b25fd35c3b789c7ff2/src/Interfaces/AbstractZonotope.jl#L358-L359