JuliaReach / LazySets.jl

Scalable symbolic-numeric set computations in Julia
https://juliareach.github.io/LazySets.jl/
Other
226 stars 32 forks source link

Remove `RotatedHyperrectangle` #3592

Closed schillic closed 2 days ago

schillic commented 1 month ago

This set type has never been used, so I suggest to remove it. (We can always recover the files from the history if desired at a later point.)

mforets commented 2 weeks ago

Type that represents a hyperrectangle that is not necessarily axis aligned.

This is a special kind of zonotope, I wonder if there are some specific features or reasons why it was added (i dont remember).

schillic commented 1 week ago

I added it back then and I think the motivation was a reachability algorithm for discrete systems where you start from a hyperrectangle and only apply linear_maps. But this is so specific that it is probably not worth keeping this type for it, even in this special case the savings are probably not significant, and we never actually used it. Here are the main differences:

In summary, I do not oppose keeping the RotatedHyperrectangle type, but since I was the one adding it and never used it, I am open to removing it. Reducing the code base has benefits as well.