JuliaReach / MathematicalSystems.jl

Systems definitions in Julia
https://juliareach.github.io/MathematicalSystems.jl/
Other
42 stars 6 forks source link

Follow-up of @system macro #133

Open mforets opened 4 years ago

mforets commented 4 years ago

Originally posted by @ueliwechsler in https://github.com/JuliaReach/MathematicalSystems.jl/pull/125#issuecomment-575240459

The following things can be done in a later PR (in approximately increasing order of work needed):

ueliwechsler commented 4 years ago

from #137:

ueliwechsler commented 4 years ago

from #139

ueliwechsler commented 4 years ago

Additionally, we should try to remove the explicit dependency on MathematicalSystems in these lines https://github.com/JuliaReach/MathematicalSystems.jl/blob/641d4f5a067f2bea6fd0dd0de7c2f193a9a8632c/src/macros.jl#L535 https://github.com/JuliaReach/MathematicalSystems.jl/blob/641d4f5a067f2bea6fd0dd0de7c2f193a9a8632c/src/macros.jl#L538

by writing push!(params, I($state_dim), :B) or something similar.