search

JuliaReach / Reachability.jl

Reachability and Safety of Nondeterministic Dynamical Systems
MIT License
50 stars 4 forks source link

Revise matrix_conversion #571

Closed schillic closed 5 years ago

schillic commented 5 years ago

We assign the result to the variable system, but only use the old variable 𝑆 in the following.

https://github.com/JuliaReach/Reachability.jl/blob/2491480904efc3d82610f745d6f38cf22fbd9eaa/src/ReachSets/ContinuousPost/BFFPSV18/BFFPSV18.jl#L252-L257

schillic commented 5 years ago

Note that we also call this method after discretization (and there we use the result). Maybe we should just move both calls to the beginning of the main reach/check_property methods.

schillic commented 5 years ago

Furthermore, the resulting system does not preserve the invariant.