search

JuliaReach / Reachability.jl

Reachability and Safety of Nondeterministic Dynamical Systems
MIT License
50 stars 4 forks source link

Port validated integ from TaylorModels #614

Closed aa25desh closed 5 years ago

aa25desh commented 5 years ago

Closes https://github.com/JuliaReach/Reachability.jl/issues/611.

mforets commented 5 years ago 
Reachability.solve_continuous: Error During Test at /home/travis/build/JuliaReach/Reachability.jl/test/Reachability/alltests.jl:2
  Got exception outside of a @test
  LoadError: UndefVarError: get_numvars not defined

-> the appropriate using is missing, in this case using TaylorSeries: get_numvars.

mforets commented 5 years ago

Please add TaylorIntegration 0.4.1 in the REQUIRE file, in order to fix the warning:

┌ Warning: Package Reachability does not have TaylorIntegration in its dependencies:
│ - If you have Reachability checked out for development and have
│   added TaylorIntegration as a dependency but haven't updated your primary
│   environment's manifest file, try `Pkg.resolve()`.
│ - Otherwise you may need to report an issue with Reachability
└ Loading TaylorIntegration into Reachability from project dependency, future warnings for Reachability are suppressed.
mforets commented 5 years ago

Thanks for the contribution!

This code is a replacement of TaylorModels.validated_integ so we need to add the copyright string, i think it's ok to add it in the same reach.jl file.

The test uses the tests for TMJets so it looks good. Also note that the build error reported in current master is not showing up (i cannot reproduce it either in my machine). Note, however, that a new warning is shown, about update! function. We can investigate it in a new issue.

In a subsequent PR we'll add early termination with invariant intersection.